Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fides Module #1073

Open
wants to merge 211 commits into
base: develop
Choose a base branch
from
Open

Fides Module #1073

wants to merge 211 commits into from

Conversation

d-strat
Copy link

@d-strat d-strat commented Nov 19, 2024

Fixes Issue

Changes proposed

Adding Fides Module, based on previous work of LukasForst. Updating, rewriting and enriching the base code.

Steps you followed to test the changes purposed in this PR:

  • Running Slips on test file with Fides Module in place
  • Tests for Fides Modules part
  • Tests for whole Fides Module

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot from 2024-11-19 21-22-07
Screenshot from 2024-11-19 21-21-38

Note to reviewers

Last update from stratosphereips (around Nov 15) passed the CI/CD pipelines.

d-strat added 30 commits October 3, 2024 11:26
…eers that are members of organisations specified on input.
modules/fidesModule/persistence/sqlite_db.py Outdated Show resolved Hide resolved
tests/integration_tests/test_fides.py Outdated Show resolved Hide resolved
print(rc.get_cached_network_opinion('stratosphere.org',0,0))

print("Deleting the output directory")
shutil.rmtree(output_dir)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is failing in CI because for some reason the dir "output/integration_tests/fides_integration_test" doesnt exist? https://github.com/stratosphereips/StratosphereLinuxIPS/actions/runs/12679148132/job/35338368100

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see it in the link, but honestly the manual debugging went perfect, while the automated one behaves so much differently.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see the error in my local testing but I will watch out for the directory

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yess true, maybe because you already have that dir created locally?

tests/integration_tests/test_fides.py Show resolved Hide resolved
tests/integration_tests/test_fides.py Outdated Show resolved Hide resolved
tests/integration_tests/test_fides.py Show resolved Hide resolved
print(db.get_cached_network_opinion('stratosphere.org', 200000000000, 200000000000))
print(rc.get_cached_network_opinion('stratosphere.org',0,0))

print("Deleting the output directory")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the output of the above prints when i run this test locally: """Checking Fides' data outlets
[]
None
None
None
None
Deleting the output directory""" that's not the expected result is it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be none, I am going to look into this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome thanks

tests/integration_tests/test_fides.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants