-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fides Module #1073
base: develop
Are you sure you want to change the base?
Fides Module #1073
Conversation
…eep progress and have a fresh start
…wledge of pubsub.
… to many ServiceHistory.
…recovery (after losing Redis data)
…eers that are members of organisations specified on input.
print(rc.get_cached_network_opinion('stratosphere.org',0,0)) | ||
|
||
print("Deleting the output directory") | ||
shutil.rmtree(output_dir) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this test is failing in CI because for some reason the dir "output/integration_tests/fides_integration_test" doesnt exist? https://github.com/stratosphereips/StratosphereLinuxIPS/actions/runs/12679148132/job/35338368100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see it in the link, but honestly the manual debugging went perfect, while the automated one behaves so much differently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not see the error in my local testing but I will watch out for the directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yess true, maybe because you already have that dir created locally?
print(db.get_cached_network_opinion('stratosphere.org', 200000000000, 200000000000)) | ||
print(rc.get_cached_network_opinion('stratosphere.org',0,0)) | ||
|
||
print("Deleting the output directory") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the output of the above prints when i run this test locally: """Checking Fides' data outlets
[]
None
None
None
None
Deleting the output directory""" that's not the expected result is it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be none, I am going to look into this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome thanks
…ate files in the output dir
Fixes Issue
Changes proposed
Adding Fides Module, based on previous work of LukasForst. Updating, rewriting and enriching the base code.
Steps you followed to test the changes purposed in this PR:
Check List (Check all the applicable boxes)
Screenshots
Note to reviewers
Last update from stratosphereips (around Nov 15) passed the CI/CD pipelines.